Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dolby Vision format handling #2023

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

ybai001
Copy link
Contributor

@ybai001 ybai001 commented Jan 8, 2025

As discussed in pull request 1785 , this pull request is created. It sets Dolby Vision codec string instead of compatible format codec string in MP4 extractor.

Further more, it added the missing DV profile 10 handling.

Merge from androidx/media main branch
* Add the missing DV profile 10 handling
* Set DV codec string instead of compatible format codec string in MP4 extractor
@ybai001
Copy link
Contributor Author

ybai001 commented Jan 10, 2025

@icbaker, as far as Dolby Vision profile specification, see: https://professionalsupport.dolby.com/s/article/What-is-Dolby-Vision-Profile?language=en_US

@FongMi
Copy link

FongMi commented Jan 10, 2025

#2024
Is there any way to prevent the green cast when watching videos on devices that do not support Dolby Profile 5 ?

@ybai001
Copy link
Contributor Author

ybai001 commented Jan 10, 2025

#2024 Is there any way to prevent the green cast when watching videos on devices that do not support Dolby Profile 5 ?

Dolby profile 5 is designed for providing best experience so that it is not backward-compatible. That is to say, unlike other profiles (e.g. profile 8/9), when app detects the content is profile 5 and device has no corresponding Dolby Vision decoder, app should reject to play this content.

@icbaker
Copy link
Collaborator

icbaker commented Jan 10, 2025

I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks!

@copybara-service copybara-service bot merged commit fda8b8a into androidx:main Jan 16, 2025
1 check passed
@ybai001 ybai001 deleted the dlb/dovi-format/dev branch January 17, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants